Page MenuHomePhabricator
Differential D11030

[web] cleanup keyserver selection modal
ClosedPublic
Actions

Authored by ginsu on Feb 12 2024, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:33 PM
Unknown Object (File)
Thu, Oct 31, 6:25 AM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Sep 22 2024, 1:18 PM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMbe7131a7038d: [web] cleanup keyserver selection modal
Summary

This diff cleans up the one off styles in the keyserver selection modal and updates the modal to follow the conventions of the new modal api

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11029

Test Plan

Please see the screenshot below

Screenshot 2024-02-12 at 4.37.16 AM.png (2×3 px, 834 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 12 2024, 1:39 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 12 2024, 1:39 AM
ginsu edited the summary of this revision. (Show Details)Feb 12 2024, 1:40 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11029: [web] cleanup add keyserver modal.
ginsu attached a referenced file: F1145151: Screenshot 2024-02-12 at 4.37.16 AM.png. (Show Details)
ginsu added a child revision: D11031: [web] introduce thread settings utils.Feb 12 2024, 1:44 AM
Harbormaster completed remote builds in B26741: Diff 36979.Feb 12 2024, 2:07 AM
ginsu requested review of this revision.Feb 12 2024, 2:07 AM
atul accepted this revision.Feb 12 2024, 12:30 PM

Can we remove extraneous <>/</>

web/modals/keyserver-selection/keyserver-selection-modal.react.js
167 ↗(On Diff #36979)

I don't think these <>/</> are necessary anymore?

This revision is now accepted and ready to land.Feb 12 2024, 12:30 PM
ginsu updated this revision to Diff 37211.Feb 15 2024, 2:16 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 2:26 AM
Closed by commit rCOMMbe7131a7038d: [web] cleanup keyserver selection modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMbe7131a7038d: [web] cleanup keyserver selection modal.
Harbormaster completed remote builds in B26905: Diff 37211.Feb 15 2024, 2:32 AM

Revision Contents
Changeset List

PathSize
web/
modals/
keyserver-selection/
12 lines
12 lines

Diff 37226

View Options

web/modals/keyserver-selection/keyserver-selection-modal.css

Loading...
View Options

web/modals/keyserver-selection/keyserver-selection-modal.react.js

Loading...