Page MenuHomePhabricator
Differential D10276

[web] cleanup sidebar promote modal
ClosedPublic
Actions

Authored by ginsu on Dec 8 2023, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 4:13 PM
Unknown Object (File)
Apr 8 2024, 1:47 PM
Unknown Object (File)
Mar 6 2024, 10:42 PM
Unknown Object (File)
Mar 6 2024, 10:42 PM
Unknown Object (File)
Mar 6 2024, 7:24 PM
Unknown Object (File)
Mar 6 2024, 7:13 PM
Unknown Object (File)
Feb 21 2024, 6:33 PM
Unknown Object (File)
Feb 21 2024, 10:43 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM247e9eddaf01: [web] cleanup sidebar promote modal
Summary

This diff cleans up the one off styles in the promote sidebar modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10273

Test Plan

Please see screenshot below

Screenshot 2023-12-08 at 4.24.26 PM.png (1×3 px, 856 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 8 2023, 12:56 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 12:56 PM
ginsu edited the summary of this revision. (Show Details)Dec 8 2023, 12:57 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10273: [web] cleanup message reactions modal.
ginsu attached a referenced file: F920647: Screenshot 2023-12-08 at 3.53.57 PM.png. (Show Details)
Harbormaster completed remote builds in B24921: Diff 34455.Dec 8 2023, 1:15 PM
ginsu requested review of this revision.Dec 8 2023, 1:15 PM
ginsu updated this revision to Diff 34457.Dec 8 2023, 1:23 PM

add double quotes

ginsu edited the test plan for this revision. (Show Details)Dec 8 2023, 1:25 PM
ginsu attached a referenced file: F920827: Screenshot 2023-12-08 at 4.24.26 PM.png. (Show Details)
ginsu added a child revision: D10279: [web] cleanup confirm leave thread modal.Dec 8 2023, 1:31 PM
Harbormaster completed remote builds in B24923: Diff 34457.Dec 8 2023, 1:42 PM
atul accepted this revision.Dec 10 2023, 5:22 PM
atul added inline comments.
web/modals/chat/sidebar-promote-modal.css
2 ↗(On Diff #34457)

Is this still needed? Can it be pulled out and handled in a "higher order" component?

This revision is now accepted and ready to land.Dec 10 2023, 5:22 PM
ginsu updated this revision to Diff 37141.Feb 15 2024, 12:22 AM

rebase before landing

Harbormaster completed remote builds in B26865: Diff 37141.Feb 15 2024, 12:37 AM
Closed by commit rCOMM247e9eddaf01: [web] cleanup sidebar promote modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM247e9eddaf01: [web] cleanup sidebar promote modal.
ginsu mentioned this in D10571: [web] introduce light mode to sidebar promote modal.Feb 20 2024, 9:11 PM

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
17 lines
36 lines

Diff 37156

View Options

web/modals/chat/sidebar-promote-modal.css

Loading...
View Options

web/modals/chat/sidebar-promote-modal.react.js

Loading...