Page MenuHomePhabricator
Differential D10316

[web] cleanup message search modal
ClosedPublic
Actions

Authored by ginsu on Dec 12 2023, 12:44 PM.
Tags
None
Referenced Files
F3294698: D10316.diff
Sat, Nov 16, 7:53 PM
Unknown Object (File)
Thu, Oct 31, 9:17 AM
Unknown Object (File)
Thu, Oct 31, 9:17 AM
Unknown Object (File)
Thu, Oct 31, 9:17 AM
Unknown Object (File)
Thu, Oct 31, 9:17 AM
Unknown Object (File)
Thu, Oct 31, 9:17 AM
Unknown Object (File)
Tue, Oct 22, 8:23 PM
Unknown Object (File)
Oct 3 2024, 6:40 PM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM35dee38b1159: [web] cleanup message search modal
Summary

This diff cleans up the one off styles in the message search modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs and https://linear.app/comm/issue/ENG-5946/fix-up-search-modal

Depends on D10315

Test Plan

Please see screenshots below

Screenshot 2023-12-12 at 3.46.19 PM.png (1×3 px, 886 KB)

Screenshot 2023-12-12 at 3.45.53 PM.png (1×3 px, 820 KB)

Screenshot 2023-12-12 at 3.46.06 PM.png (1×3 px, 892 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 12 2023, 12:44 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 12:44 PM
ginsu edited the summary of this revision. (Show Details)Dec 12 2023, 12:46 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10315: [web] cleanup thread notifications modal.
ginsu attached a referenced file: F930938: Screenshot 2023-12-12 at 3.46.06 PM.png. (Show Details)
ginsu attached a referenced file: F930939: Screenshot 2023-12-12 at 3.45.53 PM.png. (Show Details)
ginsu attached a referenced file: F930940: Screenshot 2023-12-12 at 3.46.19 PM.png. (Show Details)
ginsu added a child revision: D10317: [web] cleanup account delete modal.Dec 12 2023, 12:52 PM
Harbormaster completed remote builds in B24999: Diff 34540.Dec 12 2023, 1:19 PM
ginsu requested review of this revision.Dec 12 2023, 1:19 PM
rohan accepted this revision.Dec 12 2023, 1:20 PM
This revision is now accepted and ready to land.Dec 12 2023, 1:20 PM
ginsu updated this revision to Diff 37145.Feb 15 2024, 12:27 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
Closed by commit rCOMM35dee38b1159: [web] cleanup message search modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM35dee38b1159: [web] cleanup message search modal.
Harbormaster completed remote builds in B26869: Diff 37145.Feb 15 2024, 12:47 AM

Revision Contents
Changeset List

PathSize
web/
modals/
search/
7 lines

Diff 37160

View Options

web/modals/search/message-search-modal.css

Loading...