Page MenuHomePhabricator
Differential D11032

[web] cleanup thread settings modal delete tab
ClosedPublic
Actions

Authored by ginsu on Feb 12 2024, 1:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 6 2024, 9:54 PM
Unknown Object (File)
Mar 12 2024, 5:31 PM
Unknown Object (File)
Mar 7 2024, 1:23 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab
Summary

This diff cleans up the delete tab in the thread settings modal to follow the conventions of the new modal api. Subsquent diffs will handle the other tabs in the thread settings modal

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11031

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 12 2024, 1:47 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 12 2024, 1:47 AM
ginsu edited the summary of this revision. (Show Details)Feb 12 2024, 1:50 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11031: [web] introduce thread settings utils.
ginsu edited the test plan for this revision. (Show Details)
ginsu added inline comments.Feb 12 2024, 1:53 AM
web/modals/threads/settings/thread-settings-modal.react.js
239 ↗(On Diff #36981)

Subsequent diffs will handle the other cases for primaryButton

ginsu added a child revision: D11033: [web] cleanup thread settings relationship tab.Feb 12 2024, 1:59 AM
Harbormaster completed remote builds in B26743: Diff 36981.Feb 12 2024, 2:02 AM
ginsu requested review of this revision.Feb 12 2024, 2:02 AM
atul accepted this revision.Feb 12 2024, 12:49 PM
This revision is now accepted and ready to land.Feb 12 2024, 12:49 PM
ginsu updated this revision to Diff 37231.Feb 15 2024, 4:03 AM

rebase before landing

Harbormaster completed remote builds in B26909: Diff 37231.Feb 15 2024, 4:18 AM
Closed by commit rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab (authored by ginsu). · Explain WhyFeb 15 2024, 4:26 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab.

Revision Contents
Changeset List

Diff 37244

View Options

web/modals/threads/settings/thread-settings-delete-button.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.css

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...