Page MenuHomePhabricator
Differential D10324

[web] cleanup thread settings media gallery modal
ClosedPublic
Actions

Authored by ginsu on Dec 12 2023, 2:46 PM.
Tags
None
Referenced Files
F3299729: D10324.id34553.diff
Sun, Nov 17, 3:06 PM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Oct 3 2024, 6:09 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM3b66c2d57d79: [web] cleanup thread settings media gallery modal
Summary

This diff cleans up the one off styles in the thread settings media gallery modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs and https://linear.app/comm/issue/ENG-5944/fix-up-chat-media-modal

Depends on D10323

Test Plan

Please see screenshots below

Screenshot 2023-12-12 at 5.50.16 PM.png (1×3 px, 911 KB)

no media:

Screenshot 2023-12-12 at 5.52.43 PM.png (1×3 px, 630 KB)

no images:

Screenshot 2023-12-12 at 5.52.45 PM.png (1×3 px, 815 KB)

no videos:

Screenshot 2023-12-12 at 5.53.04 PM.png (1×3 px, 815 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 12 2023, 2:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 2:46 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 2:49 PM
Harbormaster failed remote builds in B25011: Diff 34552!
ginsu edited the summary of this revision. (Show Details)Dec 12 2023, 2:53 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10323: [web] cleanup sidebars modal.
ginsu attached a referenced file: F931954: Screenshot 2023-12-12 at 5.53.04 PM.png. (Show Details)
ginsu attached a referenced file: F931952: Screenshot 2023-12-12 at 5.52.45 PM.png. (Show Details)
ginsu attached a referenced file: F931947: Screenshot 2023-12-12 at 5.52.43 PM.png. (Show Details)
ginsu attached a referenced file: F931934: Screenshot 2023-12-12 at 5.50.16 PM.png. (Show Details)
ginsu updated this revision to Diff 34553.Dec 12 2023, 2:55 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)

update

ginsu added a comment.Dec 12 2023, 2:57 PM

will make sure ci passes before landing

ginsu published this revision for review.Dec 12 2023, 2:58 PM
Harbormaster completed remote builds in B25012: Diff 34553.Dec 12 2023, 3:31 PM
rohan accepted this revision.Dec 14 2023, 11:44 AM

Thanks for this change! The text is way better than just a blank modal

This revision is now accepted and ready to land.Dec 14 2023, 11:44 AM
ginsu added a child revision: D10344: [web] cleanup message results modal.Dec 15 2023, 12:15 AM
ashoat added a comment.Dec 15 2023, 10:14 AM

Reminder to please review all copy with me

web/modals/threads/gallery/thread-settings-media-gallery.react.js
106 ↗(On Diff #34553)

Let's strike "files" here

ginsu updated this revision to Diff 37168.Feb 15 2024, 12:52 AM

address feedback + rebase before landing

Harbormaster completed remote builds in B26877: Diff 37168.Feb 15 2024, 1:08 AM
Closed by commit rCOMM3b66c2d57d79: [web] cleanup thread settings media gallery modal (authored by ginsu). · Explain WhyFeb 15 2024, 1:18 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3b66c2d57d79: [web] cleanup thread settings media gallery modal.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
gallery/
13 lines
11 lines

Diff 37183

View Options

web/modals/threads/gallery/thread-settings-media-gallery.css

Loading...
View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

Loading...