[web] introduce clear all button to add users list
ClosedPublic
Actions

Authored by ginsu on Jan 21 2024, 12:47 PM.

Details

Reviewers

atul
inka

Commits

rCOMM2e9e01485db0: [web] introduce clear all button to add users list

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff introduces the clear all button + clear all functionality for the add users list

Linear task: https://linear.app/comm/issue/ENG-5958/clear-all-selected-functionality

Depends on D10745

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 21 2024, 12:47 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 21 2024, 12:47 PM

ginsu edited the summary of this revision. (Show Details)Jan 21 2024, 12:49 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10745: [web] introduce barebones list header section in add users list.

ginsu added inline comments.Jan 21 2024, 12:54 PM

web/theme.css
403 ↗	(On Diff #35899)	Created a linear task to better track this todo: https://linear.app/comm/issue/ENG-6496/confirm-the-link-light-mode-colors

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2024, 1:16 PM

Harbormaster failed remote builds in B25967: Diff 35899!

will make sure ci passes before landing

ginsu added a child revision: D10747: [web] update add user list header based on if searching users.Jan 21 2024, 3:08 PM

Let's move the inline CSS styles to the CSS file

web/settings/relationship/add-users-list.react.js
130–135 ↗	(On Diff #35899)	Can we move this over to the CSS file and use eg `classNames` to pull it in here.

This revision now requires changes to proceed.Jan 22 2024, 9:46 AM

Harbormaster completed remote builds in B25967: Diff 35899.Jan 22 2024, 10:03 AM

Rerequesting review after responding to concerns inline

web/settings/relationship/add-users-list.react.js
130–135 ↗	(On Diff #35899)	Noticed we followed this pattern in our codebase where we use the `buttonColor` prop to update the color of the button rather than through the `classname`. Here are a few examples: https://github.com/CommE2E/comm/blob/master/web/chat/failed-send.react.js#L86-L94 https://github.com/CommE2E/comm/blob/master/web/invite-links/manage/empty-link-content.react.js#L21-L23 https://github.com/CommE2E/comm/blob/master/web/invite-links/manage/existing-link-content.react.js#L30-L37 https://github.com/CommE2E/comm/blob/master/web/settings/relationship/friend-list-row.react.js#L67-L74 I believe that it would be best to go with what I initially proposed to keep this pattern consistent across the codebase, but lmk if you still disagree.