Page MenuHomePhabricator

[web] cleanup user list modals
ClosedPublic

Authored by ginsu on Feb 14 2024, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 10:53 AM
Unknown Object (File)
Apr 8 2024, 10:53 AM
Unknown Object (File)
Apr 8 2024, 10:53 AM
Unknown Object (File)
Apr 8 2024, 10:53 AM
Unknown Object (File)
Apr 8 2024, 10:53 AM
Unknown Object (File)
Apr 1 2024, 6:09 PM
Unknown Object (File)
Mar 6 2024, 9:24 PM
Unknown Object (File)
Mar 6 2024, 9:21 PM
Subscribers

Details

Summary

This diff cleans up the one off styles in the user list modals (friend + block lists) and updates the modal to follow the conventions of the new modal api

Please note that this modal will be fully deprecated in a few weeks in favor for the friend + block list panels in the new web ui. Just threw this diff up so that when I land all the modals, there will be no visual regressions for the time being

Depends on D11067

Test Plan

Please see the screenshot below

Screenshot 2024-02-14 at 3.07.51 AM.png (2×3 px, 765 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
This revision is now accepted and ready to land.Feb 14 2024, 8:22 PM
This revision was landed with ongoing or failed builds.Feb 15 2024, 4:26 AM
This revision was automatically updated to reflect the committed changes.