[web] move the send friend request button to add users list modal
ClosedPublic
Actions

Authored by ginsu on Jan 18 2024, 11:49 AM.

Details

Reviewers

atul
inka

Commits

rCOMM0441edeb1aa9: [web] move the send friend request button to add users list modal

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

With the new modals API introduced in D10228 we need to move + lift the logic for the send friend request button to the AddUsersListModal so that we can pass it in as the primaryButton prop

For context here is what the action button container for the add users modal should look like (subsequent diffs will handle more updates to the UI):

Screenshot 2024-01-18 at 2.58.18 PM.png (1×788 px, 130 KB)

Depends on D10344

Test Plan

flow + checked that the confirm button for the add friends modal visually follows the new modal rules:

Screenshot 2024-01-18 at 2.51.13 PM.png (3×5 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 18 2024, 11:49 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 11:49 AM

ginsu edited the summary of this revision. (Show Details)Jan 18 2024, 11:59 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu attached a referenced file: F1071480: Screenshot 2024-01-18 at 2.51.13 PM.png. (Show Details)

ginsu attached a referenced file: F1071516: Screenshot 2024-01-18 at 2.58.18 PM.png. (Show Details)

ginsu added inline comments.Jan 18 2024, 12:01 PM

web/settings/relationship/add-users-list-modal.react.js
70 ↗	(On Diff #35840)	A subsequent diff will handle fixing this, will tag when it is in review
107 ↗	(On Diff #35840)	A subsequent diff will handle fixing this, will tag when it is in review
web/settings/relationship/add-users-list.react.js
236–238 ↗	(On Diff #35840)	The new ui does not include a cancel button so we can remove this entirely

ginsu edited the summary of this revision. (Show Details)Jan 18 2024, 12:02 PM

ginsu added inline comments.

web/settings/relationship/add-users-list-modal.react.js
70 ↗	(On Diff #35840)	I didn't include it in this diff, because I felt that it would make this diff more difficult to review

Harbormaster completed remote builds in B25920: Diff 35840.Jan 18 2024, 12:25 PM

ginsu requested review of this revision.Jan 18 2024, 12:25 PM

ginsu added a child revision: D10722: [web] update add users list item ui.Jan 18 2024, 1:12 PM

fix merge conflict

ginsu added inline comments.Jan 18 2024, 2:32 PM

web/settings/relationship/add-users-list-modal.react.js
71 ↗	(On Diff #35860)	A subsequent diff will handle fixing this, will tag when it is in review. I didn't include it in this diff, because I felt that it would make this diff more difficult to review
108 ↗	(On Diff #35860)	A subsequent diff will handle fixing this, will tag when it is in review. I didn't include it in this diff, because I felt that it would make this diff more difficult to review
web/settings/relationship/add-users-list.react.js
237–239 ↗	(On Diff #35860)	The new ui does not include a cancel button so we can remove this entirely