Differential D10745

[web] introduce barebones list header section in add users list
ClosedPublic
Actions

Authored by ginsu on Jan 21 2024, 12:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 3:56 AM

	Unknown Object (File)
	Sat, Nov 9, 3:56 AM

	Unknown Object (File)
	Sat, Nov 9, 3:56 AM

	Unknown Object (File)
	Sat, Nov 9, 3:56 AM

	Unknown Object (File)
	Sat, Nov 9, 1:43 AM

	Unknown Object (File)
	Mon, Nov 4, 7:45 AM

	Unknown Object (File)
	Oct 3 2024, 3:47 PM

	Unknown Object (File)
	Oct 3 2024, 3:47 PM

View All 60 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM1157ad9132e7: [web] introduce barebones list header section in add users list

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

As part of the new add users list ui we have a header section with two parts: a text to show how many users were selected and a clear all button. This diff introduces the structure for this header section and the selection text, and a subsquent diff will handle the clear all button logic

Linear task: https://linear.app/comm/issue/ENG-5960/selected-users-section

Depends on D10743

Test Plan

Please see the demo video below

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 21 2024, 12:40 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 21 2024, 12:40 PM

ginsu edited the summary of this revision. (Show Details)Jan 21 2024, 12:44 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10743: [web] fix prop drilling within relationships modals.

ginsu edited the summary of this revision. (Show Details)Jan 21 2024, 12:48 PM

ginsu added a child revision: D10746: [web] introduce clear all button to add users list.

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2024, 1:08 PM

Harbormaster failed remote builds in B25966: Diff 35898!

will make sure ci passes before landing

Looks like CI was network issue. I'll restart

This revision is now accepted and ready to land.Jan 22 2024, 9:41 AM

Harbormaster completed remote builds in B25966: Diff 35898.Jan 22 2024, 10:01 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM

Closed by commit rCOMM1157ad9132e7: [web] introduce barebones list header section in add users list (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1157ad9132e7: [web] introduce barebones list header section in add users list.

Harbormaster completed remote builds in B26884: Diff 37175.Feb 15 2024, 1:27 AM

Revision Contents
Changeset List

Path

Size

web/

settings/

relationship/

add-users-list.css

10 lines

add-users-list.react.js

15 lines

Diff 37190

web/settings/relationship/add-users-list.css

Loading...

web/settings/relationship/add-users-list.react.js

Loading...