Differential D10322 Authored by ginsu on Dec 12 2023, 2:36 PM.
Details
Summary This diff cleans up the one off styles in the subchannels modal and replaces it with styles of the redesigned modal. Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs Depends on D10321 Test Plan please see screenshot below 
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 2:36 PM2023-12-12 14:36:26 (UTC-8) ginsu edited the summary of this revision. (Show Details)Dec 12 2023, 2:38 PM2023-12-12 14:38:49 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 2:39 PM2023-12-12 14:39:42 (UTC-8) ginsu added a child revision: D10323: [web] cleanup sidebars modal.Dec 12 2023, 2:44 PM2023-12-12 14:44:06 (UTC-8) This revision is now accepted and ready to land.Dec 14 2023, 11:43 AM2023-12-14 11:43:41 (UTC-8) This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM2024-02-15 00:44:20 (UTC-8) Closed by commit rCOMMb63853ceeb41: [web] cleanup subchannels modal (authored by ginsu). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B26875: Diff 37151.Feb 15 2024, 1:06 AM2024-02-15 01:06:20 (UTC-8)
Revision Contents
Diff 37166 |