Page MenuHomePhabricator

[web] replace AddMembersListContent experience with AddUsersList
ClosedPublic

Authored by ginsu on Feb 5 2024, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 1:05 PM
Unknown Object (File)
Apr 8 2024, 1:05 PM
Unknown Object (File)
Apr 8 2024, 1:05 PM
Unknown Object (File)
Apr 8 2024, 1:04 PM
Unknown Object (File)
Apr 8 2024, 1:04 PM
Unknown Object (File)
Mar 1 2024, 12:52 PM
Unknown Object (File)
Mar 1 2024, 12:51 PM
Unknown Object (File)
Mar 1 2024, 12:43 PM
Subscribers

Details

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

Now that useAddMembersListUserInfos has been introduced and returns all the necessary parts needed to use the checkbox add users list experience, we can now use the add users list instead of the old AddMembersListContent

Linear task: https://linear.app/comm/issue/ENG-5976/add-members-modal-experience

Depends on D10942

Test Plan

Please see the demo video below (please note there are some weird UI stuff that still needs to be polished up but a subsequent diff will fix that)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Feb 5 2024, 6:56 AM
This revision is now accepted and ready to land.Feb 5 2024, 12:13 PM