Page MenuHomePhabricator
Differential D10849

[web] fix button in add friends modal not visible on small screens
ClosedPublic
Actions

Authored by ginsu on Jan 26 2024, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 6:44 AM
Unknown Object (File)
Apr 9 2024, 12:11 AM
Unknown Object (File)
Apr 9 2024, 12:11 AM
Unknown Object (File)
Apr 9 2024, 12:11 AM
Unknown Object (File)
Apr 9 2024, 12:10 AM
Unknown Object (File)
Apr 9 2024, 12:09 AM
Unknown Object (File)
Mar 31 2024, 11:08 AM
Unknown Object (File)
Mar 5 2024, 10:03 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMMd1cbc6bf6abe: [web] fix button in add friends modal not visible on small screens
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

The cta button in the add friend/block friend modal were not visible on smaller screens. This is because we were setting a fixed height of that would extend some screens. This diff fixes that bug + some copy that was requested in the linear task.

Linear task: https://linear.app/comm/issue/ENG-6387/buttons-in-add-friends-modal-not-visible-on-small-screens

Depends on D10823

Test Plan

Please see the screenshots below

before:

Screenshot 2024-01-26 at 5.02.03 PM.png (2×3 px, 746 KB)

after:

Screenshot 2024-01-26 at 5.03.49 PM.png (2×3 px, 772 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 26 2024, 1:58 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 26 2024, 1:59 PM
ginsu edited the summary of this revision. (Show Details)Jan 26 2024, 2:04 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, ashoat.
ginsu added a parent revision: D10823: [web] update toggleUser to use previouslySelectedUsers map if previously selected user is toggled.
ginsu attached a referenced file: F1091667: Screenshot 2024-01-26 at 5.03.49 PM.png. (Show Details)
ginsu attached a referenced file: F1091666: Screenshot 2024-01-26 at 5.02.03 PM.png. (Show Details)

Made @ashoat a blocking reviewer since this diff has some copy changes

web/settings/relationship/block-users-modal.react.js
30 ↗(On Diff #36197)

Wasn't mentioned in the linear task, but figured we would also want to change this

ginsu edited the summary of this revision. (Show Details)Jan 26 2024, 2:06 PM
Harbormaster completed remote builds in B26208: Diff 36197.Jan 26 2024, 2:18 PM
ginsu requested review of this revision.Jan 26 2024, 2:18 PM
ashoat resigned from this revision.Jan 26 2024, 7:16 PM

Thanks for fixing up that copy!

atul accepted this revision.Jan 29 2024, 10:07 PM
This revision is now accepted and ready to land.Jan 29 2024, 10:07 PM
ginsu added a child revision: D10936: [web] introduce useUserRelationshipUserInfos.Feb 2 2024, 11:37 AM
ginsu updated this revision to Diff 37182.Feb 15 2024, 1:10 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:19 AM
Closed by commit rCOMMd1cbc6bf6abe: [web] fix button in add friends modal not visible on small screens (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd1cbc6bf6abe: [web] fix button in add friends modal not visible on small screens.
Harbormaster completed remote builds in B26891: Diff 37182.Feb 15 2024, 1:47 AM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
4 lines
6 lines
4 lines

Diff 37197

View Options

web/settings/relationship/add-friends-modal.react.js

Loading...
View Options

web/settings/relationship/add-users-list.css

Loading...
View Options

web/settings/relationship/block-users-modal.react.js

Loading...