Page MenuHomePhabricator
Differential D10344

[web] cleanup message results modal
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 7:21 PM
Unknown Object (File)
Apr 8 2024, 12:25 PM
Unknown Object (File)
Apr 8 2024, 12:25 PM
Unknown Object (File)
Apr 8 2024, 12:25 PM
Unknown Object (File)
Apr 8 2024, 12:25 PM
Unknown Object (File)
Apr 8 2024, 12:24 PM
Unknown Object (File)
Mar 27 2024, 9:40 AM
Unknown Object (File)
Mar 6 2024, 11:08 PM
View All 22 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMd819c32fe752: [web] cleanup message results modal
Summary

This diff cleans up the one off styles in the message results modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10324

Test Plan

Please see screenshots below

Screenshot 2023-12-15 at 3.14.33 AM.png (1×3 px, 855 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 12:12 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:12 AM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:15 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10324: [web] cleanup thread settings media gallery modal.
ginsu attached a referenced file: F951067: Screenshot 2023-12-15 at 3.14.33 AM.png. (Show Details)
ginsu added a child revision: D10345: [web] rename message results modal to be pinned messages modal.Dec 15 2023, 12:19 AM
Harbormaster completed remote builds in B25101: Diff 34688.Dec 15 2023, 12:28 AM
ginsu requested review of this revision.Dec 15 2023, 12:28 AM
rohan accepted this revision.Dec 15 2023, 8:07 AM
This revision is now accepted and ready to land.Dec 15 2023, 8:07 AM
ginsu removed a child revision: D10345: [web] rename message results modal to be pinned messages modal.Jan 4 2024, 6:29 PM
ginsu added a child revision: D10345: [web] rename message results modal to be pinned messages modal.Jan 4 2024, 6:44 PM
ginsu removed a child revision: D10345: [web] rename message results modal to be pinned messages modal.Jan 4 2024, 6:45 PM
ginsu updated this revision to Diff 37169.Feb 15 2024, 12:53 AM

rebase before landing

ginsu added a child revision: D10719: [web] move the send friend request button to add users list modal.Feb 15 2024, 12:54 AM
Harbormaster completed remote builds in B26878: Diff 37169.Feb 15 2024, 1:11 AM
Closed by commit rCOMMd819c32fe752: [web] cleanup message results modal (authored by ginsu). · Explain WhyFeb 15 2024, 1:18 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd819c32fe752: [web] cleanup message results modal.

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
14 lines
18 lines

Diff 37184

View Options

web/modals/chat/pinned-messages-modal.css

Loading...
View Options

web/modals/chat/pinned-messages-modal.react.js

Loading...