Paths

Table of Contentst

[web] cleanup enum option component when there is no icon
ClosedPublic
Actions

Authored by ginsu on Feb 13 2024, 11:06 PM.

Details

Reviewers

atul
inka

Commits

rCOMM5a837285d13d: [web] cleanup enum option component when there is no icon

Summary

As I was going through the modals, I noticed a modal that used the EnumSettingsOption but didn't have a icon with the option. The spacing/UI looked a bit off, so I took a second to fix it up

Screenshot 2024-02-14 at 2.09.26 AM.png (1×3 px, 844 KB)

Depends on D11035

Test Plan

Confirmed that the EnumSettingsOption looks fine with + w/o an icon

Screenshot 2024-02-14 at 2.10.38 AM.png (2×3 px, 892 KB)

Screenshot 2024-02-14 at 2.10.25 AM.png (2×3 px, 831 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 13 2024, 11:06 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 13 2024, 11:06 PM

ginsu edited the summary of this revision. (Show Details)Feb 13 2024, 11:11 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D11035: [web] reintroduce error message to thread settings modal.

ginsu attached a referenced file: F1150943: Screenshot 2024-02-14 at 2.10.25 AM.png. (Show Details)

ginsu attached a referenced file: F1150944: Screenshot 2024-02-14 at 2.10.38 AM.png. (Show Details)

ginsu attached a referenced file: F1150942: Screenshot 2024-02-14 at 2.09.26 AM.png. (Show Details)

ginsu added a child revision: D11064: [web] cleanup create roles modal.Feb 13 2024, 11:16 PM

Harbormaster completed remote builds in B26811: Diff 37054.Feb 13 2024, 11:22 PM

ginsu requested review of this revision.Feb 13 2024, 11:22 PM

atul accepted this revision.Feb 14 2024, 1:38 PM

atul added inline comments.

web/components/enum-settings-option.react.js
92–103 ↗	(On Diff #37054)	Wouldn't hurt to memoize, but probably wouldn't make much of a practical difference.

This revision is now accepted and ready to land.Feb 14 2024, 1:38 PM

address feedback + rebase before landing

Harbormaster completed remote builds in B26913: Diff 37235.Feb 15 2024, 4:23 AM

Closed by commit rCOMM5a837285d13d: [web] cleanup enum option component when there is no icon (authored by ginsu). · Explain WhyFeb 15 2024, 4:26 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM5a837285d13d: [web] cleanup enum option component when there is no icon.

Revision Contents
Changeset List

Path

Size

web/

components/

enum-settings-option.css

4 lines

enum-settings-option.react.js

45 lines

Diff 37248

View Options

web/components/enum-settings-option.css