[web] cleanup add members modal
ClosedPublic
Actions

Authored by ginsu on Feb 11 2024, 10:04 PM.

Details

Reviewers

atul
inka

Commits

rCOMM84492bc85a22: [web] cleanup add members modal

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

Mostly a rename diff and minor touchups to cleanup the add members modal

Linear task: https://linear.app/comm/issue/ENG-5976/add-members-modal-experience

Depends on D10944

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 11 2024, 10:04 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 11 2024, 10:04 PM

ginsu mentioned this in D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.Feb 11 2024, 10:06 PM

ginsu edited the summary of this revision. (Show Details)Feb 11 2024, 10:08 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.

Harbormaster completed remote builds in B26732: Diff 36964.Feb 11 2024, 10:20 PM

ginsu requested review of this revision.Feb 11 2024, 10:20 PM

ginsu added a child revision: D11024: [web] cleanup community creation members modal.Feb 11 2024, 10:37 PM

High level looks good, might be worth memoizing some stuff here since some of the search stuff may be "expensive"? Not really sure, and web is generally pretty performant (at least on our machines), so up to you.