Page MenuHomePhabricator
Differential D11025

[web] cleanup UnsavedChangesModal
ClosedPublic
Actions

Authored by ginsu on Feb 11 2024, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 6:40 AM
Unknown Object (File)
Thu, Oct 31, 8:25 AM
Unknown Object (File)
Oct 3 2024, 3:19 PM
Unknown Object (File)
Oct 3 2024, 3:19 PM
Unknown Object (File)
Oct 3 2024, 3:19 PM
Unknown Object (File)
Oct 3 2024, 3:19 PM
Unknown Object (File)
Oct 3 2024, 3:18 PM
Unknown Object (File)
Oct 3 2024, 12:28 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMa3df036fdb90: [web] cleanup UnsavedChangesModal
Summary

This diff cleans up the onse off styles in the UnsavedChangesModal and updates the modal to follow the conventions of the new modal api

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11024

Test Plan

Please see the screenshot below

Screenshot 2024-02-12 at 1.43.40 AM.png (2×3 px, 762 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 11 2024, 10:42 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 11 2024, 10:42 PM
ginsu edited the summary of this revision. (Show Details)Feb 11 2024, 10:43 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11024: [web] cleanup community creation members modal.
ginsu added a child revision: D11026: [web] cleanup alert modal.Feb 11 2024, 10:50 PM
Harbormaster completed remote builds in B26734: Diff 36966.Feb 11 2024, 10:58 PM
ginsu requested review of this revision.Feb 11 2024, 10:58 PM
ashoat added inline comments.Feb 12 2024, 6:04 AM
web/modals/unsaved-changes-modal.react.js
57 ↗(On Diff #36966)

This is a comma splice. Let's convert it into two sentences

atul accepted this revision.Feb 12 2024, 12:15 PM

Looks good, but make sure to address copy feedback before landing.

This revision is now accepted and ready to land.Feb 12 2024, 12:15 PM
ginsu updated this revision to Diff 37207.Feb 15 2024, 2:12 AM

address comments + rebase before landing

Harbormaster completed remote builds in B26901: Diff 37207.Feb 15 2024, 2:26 AM
Closed by commit rCOMMa3df036fdb90: [web] cleanup UnsavedChangesModal (authored by ginsu). · Explain WhyFeb 15 2024, 2:26 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa3df036fdb90: [web] cleanup UnsavedChangesModal.

Revision Contents
Changeset List

Diff 37223

View Options

web/modals/unsaved-changes-modal.css

Loading...
View Options

web/modals/unsaved-changes-modal.react.js

Loading...