Page MenuHomePhabricator

[web] cleanup compose subchannel modal
ClosedPublic

Authored by ginsu on Feb 13 2024, 11:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 10 2024, 1:06 PM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Apr 8 2024, 10:07 AM
Unknown Object (File)
Mar 20 2024, 4:59 AM
Subscribers

Details

Summary

This diff cleans up the one off styles in the compose subchannel modal and updates the modal to follow the conventions of the new modal api.

Linear task: https://linear.app/comm/issue/ENG-6735/add-member-list-for-subchannel-creation-is-not-reflecting-the-correct

Depends on D11065

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
web/theme.css
185–188 ↗(On Diff #37058)

Confirmed that these variables weren't being used anywhere

atul added inline comments.
web/modals/threads/create/compose-subchannel-modal.css
4 ↗(On Diff #37058)

Idk all the details on design system naming convention, but seems weird that text (which I perceive as "foreground") has a color with "background" in the name?

Could be totally fine and defer to you because you have much more context, but figured I'd leave a note.

web/modals/threads/create/compose-subchannel-modal.react.js
201–206 ↗(On Diff #37058)

Could be simplified w/ ternary if you want, totally up to you

const modalContent = React.useMemo(
  () => (activeStep === 'settings' ? subchannelSettings : subchannelMembers),
  [activeStep, subchannelMembers, subchannelSettings],
);
This revision is now accepted and ready to land.Feb 14 2024, 8:17 PM
web/modals/threads/create/compose-subchannel-modal.css
4 ↗(On Diff #37058)

Since we moved to a component family based naming convention, "background" is the property name for the "text" color family

web/modals/threads/create/compose-subchannel-modal.react.js
201–206 ↗(On Diff #37058)

Going to keep it as is, in case we decide to add more steps in the future

This revision was landed with ongoing or failed builds.Feb 15 2024, 4:26 AM
This revision was automatically updated to reflect the committed changes.