Page MenuHomePhabricator

[web] cleanup thread settings relationship tab
ClosedPublic

Authored by ginsu on Feb 12 2024, 1:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Apr 8 2024, 11:47 AM
Unknown Object (File)
Mar 12 2024, 8:09 PM
Unknown Object (File)
Mar 12 2024, 6:24 PM
Unknown Object (File)
Mar 7 2024, 2:20 AM
Unknown Object (File)
Feb 21 2024, 3:41 AM
Subscribers

Details

Summary

This diff cleans up the relationship tab in the thread settings modal to follow the conventions of the new modal api. Subsequent diffs will handle the other tabs in the thread settings modal.

The relationship tab actually does not have a primary button; however, if we don't pass in a placeholder primary button, the thread settings modal will change height + position, so I added a placeholder div so the following does not happen

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11032

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added inline comments.
web/modals/threads/settings/thread-settings-modal.css
5–9 ↗(On Diff #36986)

Snuck some minor cosmetic changes to the thread settings modal

ginsu requested review of this revision.Feb 12 2024, 2:11 AM
atul added inline comments.
web/modals/threads/settings/thread-settings-modal.react.js
242–247 ↗(On Diff #36986)

Stylistically prefer else if, but doesn't matter

This revision is now accepted and ready to land.Feb 12 2024, 12:50 PM