Page MenuHomePhabricator

[web] match the veritcal padding for modals with no button containers
ClosedPublic

Authored by ginsu on Dec 7 2023, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Apr 8 2024, 2:32 PM
Unknown Object (File)
Mar 6 2024, 10:07 PM
Unknown Object (File)
Mar 6 2024, 10:07 PM
Unknown Object (File)
Mar 6 2024, 7:02 PM
Subscribers

Details

Summary

Some modals will not have a CTA/button section. If that is the case the padding of the modal will be top: 32px, horizontal: 32px and bottom: 24px. This is based off the rules below:

Screenshot 2023-12-07 at 3.18.13 PM.png (818×818 px, 50 KB)

To make sure the vertical padding for modals is equal to each other when there is no button section, I added an empty div with a height of 8px to act as on offset so that if there is no button section then the modal will just have a 32px uniform padding across all of its sides

Depends on D10236

Test Plan

Please see screenshot of my inspector showing the correct dimensions below for a modal with no CTA/button section

top has padding of 32px:

Screenshot 2023-12-07 at 3.23.00 PM.png (1×3 px, 1 MB)

horizontal sides have padding of 32px + bottom of 24px

Screenshot 2023-12-07 at 3.23.13 PM.png (1×3 px, 1 MB)

bottom offset of 8px (24+8 = 32)

Screenshot 2023-12-07 at 3.23.16 PM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Dec 7 2023, 1:51 PM
This revision is now accepted and ready to land.Dec 8 2023, 5:05 AM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:10 AM
This revision was automatically updated to reflect the committed changes.