HomePhabricator
Diffusion Comm b7dcd3f40bdb

[web] match the veritcal padding for modals with no button containers

Description

[web] match the veritcal padding for modals with no button containers

Summary:
Some modals will not have a CTA/button section. If that is the case the padding of the modal will be top: 32px, horizontal: 32px and bottom: 24px. This is based off the rules below:

Screenshot 2023-12-07 at 3.18.13 PM.png (818×818 px, 50 KB)

To make sure the vertical padding for modals is equal to each other when there is no button section, I added an empty div with a height of 8px to act as on offset so that if there is no button section then the modal will just have a 32px uniform padding across all of its sides

Depends on D10236

Test Plan:
Please see screenshot of my inspector showing the correct dimensions below for a modal with no CTA/button section

top has padding of 32px:

Screenshot 2023-12-07 at 3.23.00 PM.png (1×3 px, 1 MB)

horizontal sides have padding of 32px + bottom of 24px

Screenshot 2023-12-07 at 3.23.13 PM.png (1×3 px, 1 MB)

bottom offset of 8px (24+8 = 32)

Screenshot 2023-12-07 at 3.23.16 PM.png (1×3 px, 1 MB)

Reviewers: atul, rohan, kamil

Reviewed By: rohan

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10237

Details

Provenance
ginsuAuthored on Dec 6 2023, 10:57 PM
Reviewer
rohan
Differential Revision
D10237: [web] match the veritcal padding for modals with no button containers
Parents
rCOMM7d9860b5542f: [web] cleanup community creation modal
Branches
Unknown
Tags
Unknown