Page MenuHomePhabricator
Differential D10943

[web] replace AddMembersListContent experience with AddUsersList
ClosedPublic
Actions

Authored by ginsu on Feb 5 2024, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 8:25 AM
Unknown Object (File)
Oct 3 2024, 2:48 PM
Unknown Object (File)
Oct 3 2024, 2:48 PM
Unknown Object (File)
Oct 3 2024, 2:48 PM
Unknown Object (File)
Oct 3 2024, 2:47 PM
Unknown Object (File)
Oct 3 2024, 2:47 PM
Unknown Object (File)
Aug 29 2024, 8:48 AM
Unknown Object (File)
Aug 29 2024, 7:14 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMab7066dff625: [web] replace AddMembersListContent experience with AddUsersList
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

Now that useAddMembersListUserInfos has been introduced and returns all the necessary parts needed to use the checkbox add users list experience, we can now use the add users list instead of the old AddMembersListContent

Linear task: https://linear.app/comm/issue/ENG-5976/add-members-modal-experience

Depends on D10942

Test Plan

Please see the demo video below (please note there are some weird UI stuff that still needs to be polished up but a subsequent diff will fix that)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 5 2024, 6:37 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 5 2024, 6:37 AM
ginsu edited the summary of this revision. (Show Details)Feb 5 2024, 6:40 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10942: [web] introduce useAddMembersListUserInfos.
ginsu edited the summary of this revision. (Show Details)Feb 5 2024, 6:45 AM
ginsu added a child revision: D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.
Harbormaster completed remote builds in B26495: Diff 36619.Feb 5 2024, 6:56 AM
ginsu requested review of this revision.Feb 5 2024, 6:56 AM
atul accepted this revision.Feb 5 2024, 12:13 PM
This revision is now accepted and ready to land.Feb 5 2024, 12:13 PM
ginsu updated this revision to Diff 37203.Feb 15 2024, 1:38 AM

rebase before landing

Harbormaster completed remote builds in B26897: Diff 37203.Feb 15 2024, 2:01 AM
Closed by commit rCOMMab7066dff625: [web] replace AddMembersListContent experience with AddUsersList (authored by ginsu). · Explain WhyFeb 15 2024, 2:26 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMab7066dff625: [web] replace AddMembersListContent experience with AddUsersList.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
42 lines

Diff 36619

View Options

web/modals/threads/members/add-members-modal.react.js

Loading...