Differential D11032 Authored by ginsu on Feb 12 2024, 1:47 AM.
Tags None Referenced Files
Details
Summary This diff cleans up the delete tab in the thread settings modal to follow the conventions of the new modal api. Subsquent diffs will handle the other tabs in the thread settings modal Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs Depends on D11031 Test Plan Please see the demo video below
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 12 2024, 1:47 AM2024-02-12 01:47:38 (UTC-8) ginsu edited the summary of this revision. (Show Details)Feb 12 2024, 1:50 AM2024-02-12 01:50:31 (UTC-8)
Harbormaster completed remote builds in B26743: Diff 36981.Feb 12 2024, 2:02 AM2024-02-12 02:02:10 (UTC-8) This revision is now accepted and ready to land.Feb 12 2024, 12:49 PM2024-02-12 12:49:46 (UTC-8) Harbormaster completed remote builds in B26909: Diff 37231.Feb 15 2024, 4:18 AM2024-02-15 04:18:55 (UTC-8) Closed by commit rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab (authored by ginsu). · Explain WhyFeb 15 2024, 4:26 AM2024-02-15 04:26:16 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 36981 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||