Page MenuHomePhabricator
Differential D10742

[web] fix add users list modal functionality
ClosedPublic
Actions

Authored by ginsu on Jan 19 2024, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:55 AM
Unknown Object (File)
Tue, Nov 12, 11:49 PM
Unknown Object (File)
Tue, Nov 12, 5:09 AM
Unknown Object (File)
Mon, Nov 11, 11:43 PM
Unknown Object (File)
Sun, Nov 10, 2:34 PM
Unknown Object (File)
Sun, Nov 10, 2:19 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMc406518a2083: [web] fix add users list modal functionality
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

In D10719 I had to lift the logic for the send friend requests button to the AddUsersListModal component. To make things easier to review, I lifted part of the logic and created a few TODOs for me to circle back to (specifically with the logic for the pending users since that was going to have significant changes with the new checkbox ux)

This diff lifts the pendingUsersToAdd set to the AddUsersListModal component, and with pendingUsersToAdd now in AddUsersListModal I can fix up all the TODOs I set in D10719, and all the functionality should be working again

Linear task: https://linear.app/comm/issue/ENG-5957/update-the-ui-of-add-friends-modal

Depends on D10735

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 19 2024, 8:32 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 19 2024, 8:32 AM
ginsu edited the summary of this revision. (Show Details)Jan 19 2024, 8:44 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10735: [web] update add friends modal selection logic.
ginsu attached a referenced file: F1073425: Screen Recording 2024-01-19 at 11.36.44 AM.mov. (Show Details)
ginsu mentioned this in D10719: [web] move the send friend request button to add users list modal.
ginsu edited the summary of this revision. (Show Details)Jan 19 2024, 8:47 AM
Harbormaster completed remote builds in B25960: Diff 35890.Jan 19 2024, 8:53 AM
ginsu requested review of this revision.Jan 19 2024, 8:53 AM
ginsu added a child revision: D10743: [web] fix prop drilling within relationships modals.Jan 19 2024, 11:36 AM
atul accepted this revision.Jan 22 2024, 9:38 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:38 AM
ginsu updated this revision to Diff 37173.Feb 15 2024, 12:59 AM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM
Closed by commit rCOMMc406518a2083: [web] fix add users list modal functionality (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc406518a2083: [web] fix add users list modal functionality.
Harbormaster completed remote builds in B26882: Diff 37173.Feb 15 2024, 1:23 AM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
21 lines
15 lines

Diff 35890

View Options

web/settings/relationship/add-users-list-modal.react.js

Loading...
View Options

web/settings/relationship/add-users-list.react.js

Loading...