HomePhabricator
Diffusion Comm 777c5f57ace0

[native] introduced flow type for @expo/react-native-action-sheet

Description

[native] introduced flow type for @expo/react-native-action-sheet

Summary:
Now that we are using @expo/react-native-action-sheet we need to introduce the following flow types to use the action sheet in our codebase. I read through the source code, and used types.ts when writing the flow types.


Linear Task: ENG-2145

Test Plan: All the testing for this diff came from its use in D5524. In that diff I was able to implement the action sheet using the flow types I created in this diff, and I received no flow errors which I believe to be a good indicator that everything is correct. I noticed in the flow docs, there was a section to write tests; however, I also noticed that the other flow-typed library definitions in our code base also don't have any tests, but if this is something we want to get done, I will take a look into it

Reviewers: ashoat, atul

Reviewed By: ashoat, atul

Subscribers: ashoat, tomek, atul, abosh

Differential Revision: https://phab.comm.dev/D5523

Details

Provenance
ginsuAuthored on Nov 7 2022, 7:21 AM
Reviewer
ashoat
Differential Revision
D5523: [native] introduced flow type for @expo/react-native-action-sheet
Parents
rCOMM565ebe619583: [native] Update to react-native@0.66.5
Branches
Unknown
Tags
Unknown