HomePhabricator
Diffusion Comm 790ce888a015

[landing] clean up competitor comparison UI

Description

[landing] clean up competitor comparison UI

Summary:
As I was inputting copy for one of the competitors I came across some modals/elements that were not super clean visaully. Spoke with @ted and he gave me some tips on how to clean things up.

  1. We should make the padding for the modal container 32px all around
  2. The descriptions in the competitor feature comparison modal should not have a min height
  3. The dividers in the competitor feature cards that have are a tad off

Linear task: https://linear.app/comm/issue/ENG-4346/remove-min-height-for-competitor-feature-comparison-modal

Depends on D8176

Test Plan:
Please see the screenshots below to see that each point in the summary was addressed:

We should make the padding for the modal container 32px all around

Before:

Screenshot 2023-07-11 at 4.33.20 PM.png (2×3 px, 922 KB)

After:

Screenshot 2023-07-11 at 4.33.34 PM.png (2×3 px, 921 KB)

The descriptions in the competitor feature comparison modal should not have a min height

Before:

Screenshot 2023-07-07 at 4.34.32 PM.png (2×3 px, 916 KB)

After:

Screenshot 2023-07-11 at 4.34.53 PM.png (2×3 px, 860 KB)

The dividers in the competitor feature cards that have are a tad off

Before:

Screenshot 2023-07-11 at 4.13.03 PM.png (2×3 px, 758 KB)

After:

Screenshot 2023-07-11 at 4.35.30 PM.png (2×3 px, 846 KB)

Reviewers: atul, kamil

Reviewed By: atul, kamil

Subscribers: ashoat, tomek, ted

Differential Revision: https://phab.comm.dev/D8477

Details

Provenance
ginsuAuthored on Jul 11 2023, 1:18 PM
Reviewer
atul
Differential Revision
D8477: [landing] clean up competitor comparison UI
Parents
rCOMMd568c898c615: [landing] fix size prop for icons in mobile nav
Branches
Unknown
Tags
Unknown