HomePhabricator
Diffusion Comm 7a0c568d895a

[lib] Accept keyserver ID in blob service upload action

Description

[lib] Accept keyserver ID in blob service upload action

Summary:
Due to changes in D9399 the blob service upload action now requires threadID to extract keyserver ID from it. It is needed to determine which keyserver we want to send upload metatata to.

The thread ID is unavailable in some context, e.g. for user avatars. However, the extraction function is a no-op if we passed keyserver ID already so renamed the input argument to indicate that.

More context in ENG-5673.

Test Plan:

  • Created another unit test for extractKeyserverIdFromID()
  • Flow passes
  • Multimedia uplaods still work
  • Avatars tested together with other diffs in this stack (two child diffs)

Reviewers: inka, michal, tomek, ashoat

Reviewed By: inka

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9738

Details

Provenance
bartekAuthored on Nov 7 2023, 12:02 AM
Reviewer
inka
Differential Revision
D9738: [lib] Accept keyserver ID in blob service upload action
Parents
rCOMMa7af2c5424d3: [web] Display encrypted image avatars
Branches
Unknown
Tags
Unknown