Page MenuHomePhabricator

[lib][web][native] Refactor actions in upload-actions.js
ClosedPublic

Authored by inka on Oct 6 2023, 8:42 AM.
Tags
None
Referenced Files
F3376099: D9399.id.diff
Tue, Nov 26, 10:17 PM
Unknown Object (File)
Sat, Nov 23, 4:24 PM
Unknown Object (File)
Wed, Nov 20, 3:15 AM
Unknown Object (File)
Sat, Nov 2, 6:55 AM
Unknown Object (File)
Oct 27 2024, 9:48 PM
Unknown Object (File)
Oct 27 2024, 9:48 PM
Unknown Object (File)
Oct 27 2024, 9:48 PM
Unknown Object (File)
Oct 27 2024, 9:36 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions
uploadMultimedia will be replaced by useBlobServiceUpload once blob service starts working. uploadMediaMetadata was not being used and is not needed anymore, as explained in https://linear.app/comm/issue/ENG-5174/get-rid-of-uploadmediametadata-action

Test Plan

Tested the deleteUpload action. The change to blobServiceUpload is the same as the changes to multiple actions before, so I think it's fair to assume that it's working after countless other actions with the same changes have been tested. The problem with testing it is that it calls the blob service and would break the db state

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Oct 6 2023, 9:00 AM

(I think you are missing a stack for this diff)

This revision is now accepted and ready to land.Oct 11 2023, 1:43 AM

Move await to the top level