Paths

Table of Contentst

Differential D9225

[lib] Create function for extracing keyserver id from object id
ClosedPublic
Actions

Authored by inka on Sep 19 2023, 2:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 11:02 AM

	Unknown Object (File)
	Mon, Dec 16, 12:49 AM

	Unknown Object (File)
	Tue, Dec 10, 9:37 PM

	Unknown Object (File)
	Sat, Dec 7, 2:51 PM

	Unknown Object (File)
	Thu, Dec 5, 7:42 AM

	Unknown Object (File)
	Tue, Dec 3, 8:18 PM

	Unknown Object (File)
	Tue, Nov 26, 4:39 AM

	Unknown Object (File)
	Nov 24 2024, 12:58 AM

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM0c123b4904c0: [lib] Create function for extracing keyserver id from object id

Summary

issue: https://linear.app/comm/issue/ENG-4682/create-a-function-to-extract-keyserver-id-from-ids
We need a function that will allow us to extract the keyserver id from message/thread/etc id

Test Plan

Ran the provided test suite

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Sep 19 2023, 2:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 19 2023, 2:08 AM

inka added a parent revision: D9217: [lib] Add logic for handling faonut actions.Sep 19 2023, 2:08 AM

Harbormaster completed remote builds in B22713: Diff 31249.Sep 19 2023, 2:24 AM

inka requested review of this revision.Sep 19 2023, 2:24 AM

tomek added inline comments.Sep 19 2023, 2:51 AM

lib/utils/action-utils.js
42–46 ↗	(On Diff #31249)	Wondering if we really have to match against two regexes. Can we simplify it and use only one?
47 ↗	(On Diff #31249)	Can't we simply call `return id.split('\|')[0];`?

inka added a child revision: D9226: [lib] Update KeyserverCall type.Sep 19 2023, 8:09 AM

This does not handle pending threads (more precisely sidebars created from a message). It's might be fine depending on the use case but I it feel like it should have a code comment in that case. Also agree with @tomek comments.

This does not handle pending threads (more precisely sidebars created from a message)

Pending threads exist in two contexts: pending sidebars, and pending chats created via the "Create new chat" interface.

Curiously, it does appear that BaseNewThreadRequest takes an optional id field. However, threadRequestValidationShape excludes this, meaning that it's only possible to set the id of a new thread from the keyserver. As such, I don't think pending thread IDs ever get passed up in an action... so this should (hopefully) be safe.

Simplify

inka added a child revision: D9240: [lib][web][native] Refactor actions in message-actions.js.Oct 3 2023, 3:45 AM

Harbormaster completed remote builds in B22944: Diff 31605.Oct 3 2023, 4:02 AM

Fix type

Harbormaster completed remote builds in B22949: Diff 31610.Oct 3 2023, 7:03 AM

michal accepted this revision.Oct 4 2023, 6:54 AM

This revision is now accepted and ready to land.Oct 4 2023, 6:54 AM

Closed by commit rCOMM0c123b4904c0: [lib] Create function for extracing keyserver id from object id (authored by inka). · Explain WhyNov 6 2023, 4:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0c123b4904c0: [lib] Create function for extracing keyserver id from object id.

Revision Contents
Changeset List

Path

Size

lib/

utils/

action-utils.js

5 lines

action-utils.test.js

11 lines

Diff 32751

lib/utils/action-utils.js

Loading...

lib/utils/action-utils.test.js

Loading...