Page MenuHomePhabricator

[lib][web][native] Refactor actions in user-actions.js pt.1
ClosedPublic

Authored by inka on Oct 16 2023, 5:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:36 PM
Unknown Object (File)
Fri, Nov 8, 3:39 PM
Unknown Object (File)
Fri, Nov 8, 7:43 AM
Unknown Object (File)
Fri, Nov 8, 7:33 AM
Unknown Object (File)
Fri, Nov 8, 5:34 AM
Unknown Object (File)
Mon, Oct 28, 2:27 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions
Some more actions from this file will be updated in the next diff

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Oct 16 2023, 5:50 AM
michal added inline comments.
lib/actions/user-actions.js
295–306 ↗(On Diff #32035)

We will probably have to think how the settings will work in multi-keyserver world but this should be fine for now (I think we are currently only storing which threads are in the background).

This revision is now accepted and ready to land.Oct 16 2023, 7:29 AM
lib/actions/user-actions.js
295–306 ↗(On Diff #32035)

Is this "user settings" just the default notif settings? If so I think we'll want this to:

  1. Be synced between clients (Olm messages through Tunnelbroker)
  2. Be synced to all keyservers you're part of
  3. Eventually when we launch DMs, we'll want it to be synced to all peers as well

Maybe we can add a Linear task under ENG-4138? cc @tomek, who has been investigating this recently

lib/actions/user-actions.js
295–306 ↗(On Diff #32035)

Wondering if we would like to have different settings for different keyservers - sounds quite useful. Regardless, it makes sense to have a task for it - @inka could you create one?

lib/actions/user-actions.js
295–306 ↗(On Diff #32035)

Sure, here is the task: ENG-5650