Paths

Table of Contentst

Differential D9501

[lib][web][native] Refactor actions in user-actions.js pt.1
ClosedPublic
Actions

Authored by inka on Oct 16 2023, 5:31 AM.

Tags

None

Referenced Files

	F3378638: D9501.diff
	Wed, Nov 27, 12:03 PM

	Unknown Object (File)
	Sat, Nov 23, 11:38 PM

	Unknown Object (File)
	Sat, Nov 23, 11:26 PM

	Unknown Object (File)
	Wed, Nov 20, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 3:39 PM

	Unknown Object (File)
	Fri, Nov 8, 7:43 AM

	Unknown Object (File)
	Fri, Nov 8, 7:33 AM

	Unknown Object (File)
	Fri, Nov 8, 5:34 AM

View All 91 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM6fb06ac6680f: [lib][web][native] Refactor actions in user-actions.js pt.1

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions
Some more actions from this file will be updated in the next diff

Test Plan

Tested that the actions work as expected

Diff Detail

Repository

Branch

inka/actions_new_branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 16 2023, 5:31 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 16 2023, 5:31 AM

inka added a parent revision: D9399: [lib][web][native] Refactor actions in upload-actions.js.Oct 16 2023, 5:32 AM

Harbormaster completed remote builds in B23262: Diff 32035.Oct 16 2023, 5:50 AM

inka requested review of this revision.Oct 16 2023, 5:50 AM

michal accepted this revision.Oct 16 2023, 7:29 AM

michal added inline comments.

lib/actions/user-actions.js
295–306	We will probably have to think how the settings will work in multi-keyserver world but this should be fine for now (I think we are currently only storing which threads are in the background).

This revision is now accepted and ready to land.Oct 16 2023, 7:29 AM

ashoat added inline comments.Oct 18 2023, 4:37 PM

lib/actions/user-actions.js
295–306	Is this "user settings" just the default notif settings? If so I think we'll want this to: Be synced between clients (Olm messages through Tunnelbroker) Be synced to all keyservers you're part of Eventually when we launch DMs, we'll want it to be synced to all peers as well Maybe we can add a Linear task under ENG-4138? cc @tomek, who has been investigating this recently

tomek added inline comments.Oct 19 2023, 5:21 AM

lib/actions/user-actions.js
295–306	Wondering if we would like to have different settings for different keyservers - sounds quite useful. Regardless, it makes sense to have a task for it - @inka could you create one?

inka added a child revision: D9628: [lib][web][native] Refactor setDeviceToken action.Oct 30 2023, 6:46 AM

inka added inline comments.Nov 2 2023, 10:27 AM

lib/actions/user-actions.js
295–306	Sure, here is the task: ENG-5650

Move await to top level

Harbormaster completed remote builds in B23682: Diff 32636.Nov 2 2023, 11:27 AM

Closed by commit rCOMM6fb06ac6680f: [lib][web][native] Refactor actions in user-actions.js pt.1 (authored by inka). · Explain WhyNov 6 2023, 5:45 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM6fb06ac6680f: [lib][web][native] Refactor actions in user-actions.js pt.1.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

75 lines

native/

chat/

settings/

thread-settings-home-notifs.react.js

9 lines

thread-settings-push-notifs.react.js

9 lines

profile/

default-notifications-preferences.react.js

5 lines

web/

modals/

threads/

notifications/

notifications-modal.react.js

9 lines

Diff 32035

lib/actions/user-actions.js

Loading...

native/chat/settings/thread-settings-home-notifs.react.js

Loading...

native/chat/settings/thread-settings-push-notifs.react.js

Loading...

native/profile/default-notifications-preferences.react.js

Loading...

web/modals/threads/notifications/notifications-modal.react.js

Loading...