Page MenuHomePhabricator
Differential D9371

[lib][web][native] Refactor actions in thread-actions.js pt.2
ClosedPublic
Actions

Authored by inka on Oct 5 2023, 9:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 3:01 AM
Unknown Object (File)
Tue, Mar 18, 3:01 AM
Unknown Object (File)
Tue, Mar 18, 3:01 AM
Unknown Object (File)
Tue, Mar 18, 3:00 AM
Unknown Object (File)
Tue, Mar 18, 2:48 AM
Unknown Object (File)
Sat, Mar 8, 9:58 AM
Unknown Object (File)
Fri, Mar 7, 3:33 AM
Unknown Object (File)
Thu, Feb 27, 3:57 PM
View All Files
Subscribers
ashoat
marcin
tomek
will

Details

Reviewers
michal
kamil
ginsu
marcin
Commits
rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2
Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

also removed accountPassword argument, that was deprecated by this stack: https://phab.comm.dev/D6103
Adding @marcin to review, since it was their stack

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Oct 5 2023, 9:44 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 9:44 AM
inka added a parent revision: D9370: [lib][web][native] Refactor actions in thread-actions.js pt.1.Oct 5 2023, 9:46 AM
Harbormaster completed remote builds in B23006: Diff 31686.Oct 5 2023, 10:02 AM
inka requested review of this revision.Oct 5 2023, 10:02 AM
marcin accepted this revision.Oct 6 2023, 4:26 AM
This revision is now accepted and ready to land.Oct 6 2023, 4:26 AM
michal requested changes to this revision.Oct 11 2023, 1:38 AM
michal added inline comments.
keyserver/src/responders/thread-responders.js
69 ↗(On Diff #31686)

If I remember correctly this will stop accepting requests from older clients (because they will still send accountPassword). We should probably leave the validator as it is and change the ThreadDeletionRequest.accountPassword to (optional) empty so flow complains if you try and do anything with it.

lib/actions/thread-actions.js
44 ↗(On Diff #31686)

We shouldn't hide await inside of an another expression

This revision now requires changes to proceed.Oct 11 2023, 1:38 AM
inka added a child revision: D9399: [lib][web][native] Refactor actions in upload-actions.js.Oct 17 2023, 3:42 AM
inka updated this revision to Diff 32633.Nov 2 2023, 10:13 AM

Address review

Harbormaster completed remote builds in B23679: Diff 32633.Nov 2 2023, 10:56 AM
michal accepted this revision.Nov 3 2023, 5:19 AM
This revision is now accepted and ready to land.Nov 3 2023, 5:19 AM
Closed by commit rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2 (authored by inka). · Explain WhyNov 6 2023, 5:45 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2.
inka mentioned this in D10591: [lib] Fix types in deleteThread.Jan 10 2024, 5:36 AM
inka mentioned this in rCOMM9fb4ba10c29b: [lib] Fix types in deleteThread.Jan 16 2024, 1:52 AM

Revision Contents
Changeset List

Diff 32763

View Options

lib/actions/thread-actions.js

// @flow // @flow
import reduceCalendarFilters from './calendar-filters-reducer.js'; import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js'; import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js'; import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js'; import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js'; import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js'; import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js'; import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js'; import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js'; import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js'; import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines state: {
action, action,
), ),
lifecycleState: reduceLifecycleState(state.lifecycleState, action), lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action), enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore, reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action), nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action), dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action), userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken( commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken, state.commServicesAccessToken,
action, action,
), ),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action), inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore, keyserverStore,
threadActivityStore: reduceThreadActivity( threadActivityStore: reduceThreadActivity(
state.threadActivityStore, state.threadActivityStore,
Show All 18 Lines
View Options

lib/components/base-edit-thread-avatar-provider.react.js

// @flow // @flow
import reduceCalendarFilters from './calendar-filters-reducer.js'; import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js'; import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js'; import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js'; import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js'; import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js'; import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js'; import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js'; import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js'; import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js'; import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines state: {
action, action,
), ),
lifecycleState: reduceLifecycleState(state.lifecycleState, action), lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action), enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore, reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action), nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action), dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action), userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken( commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken, state.commServicesAccessToken,
action, action,
), ),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action), inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore, keyserverStore,
threadActivityStore: reduceThreadActivity( threadActivityStore: reduceThreadActivity(
state.threadActivityStore, state.threadActivityStore,
Show All 18 Lines
View Options

lib/hooks/promote-sidebar.react.js

// @flow // @flow
import reduceCalendarFilters from './calendar-filters-reducer.js'; import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js'; import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js'; import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js'; import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js'; import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js'; import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js'; import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js'; import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js'; import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js'; import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines state: {
action, action,
), ),
lifecycleState: reduceLifecycleState(state.lifecycleState, action), lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action), enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore, reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action), nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action), dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action), userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken( commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken, state.commServicesAccessToken,
action, action,
), ),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action), inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore, keyserverStore,
threadActivityStore: reduceThreadActivity( threadActivityStore: reduceThreadActivity(
state.threadActivityStore, state.threadActivityStore,
Show All 18 Lines
View Options

lib/shared/messages/text-message-spec.js

// @flow // @flow
import reduceCalendarFilters from './calendar-filters-reducer.js'; import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js'; import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js'; import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js'; import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js'; import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js'; import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js'; import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js'; import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js'; import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js'; import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines state: {
action, action,
), ),
lifecycleState: reduceLifecycleState(state.lifecycleState, action), lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action), enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore, reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action), nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action), dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action), userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken( commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken, state.commServicesAccessToken,
action, action,
), ),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action), inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore, keyserverStore,
threadActivityStore: reduceThreadActivity( threadActivityStore: reduceThreadActivity(
state.threadActivityStore, state.threadActivityStore,
Show All 18 Lines
View Options

lib/types/thread-types.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/community-creation/community-creation-members.react.js

Loading...
View Options

web/modals/threads/members/add-members-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...