Paths

Table of Contentst

Differential D9371

[lib][web][native] Refactor actions in thread-actions.js pt.2
ClosedPublic
Actions

Authored by inka on Oct 5 2023, 9:44 AM.

Tags

None

Referenced Files

	F3388296: D9371.id31686.diff
	Fri, Nov 29, 1:36 PM

	Unknown Object (File)
	Thu, Nov 28, 3:36 AM

	Unknown Object (File)
	Tue, Nov 26, 2:18 PM

	Unknown Object (File)
	Sat, Nov 23, 10:35 PM

	Unknown Object (File)
	Wed, Nov 20, 5:38 PM

	Unknown Object (File)
	Wed, Nov 20, 2:58 PM

	Unknown Object (File)
	Sun, Nov 17, 6:41 AM

	Unknown Object (File)
	Fri, Nov 15, 2:30 AM

View All 95 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu
marcin

Commits

rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

also removed accountPassword argument, that was deprecated by this stack: https://phab.comm.dev/D6103
Adding @marcin to review, since it was their stack

Test Plan

Tested that the actions work as expected

Diff Detail

Repository

Branch

inka/actions_new_branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 5 2023, 9:44 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 9:44 AM

inka added a parent revision: D9370: [lib][web][native] Refactor actions in thread-actions.js pt.1.Oct 5 2023, 9:46 AM

Harbormaster completed remote builds in B23006: Diff 31686.Oct 5 2023, 10:02 AM

inka requested review of this revision.Oct 5 2023, 10:02 AM

marcin accepted this revision.Oct 6 2023, 4:26 AM

This revision is now accepted and ready to land.Oct 6 2023, 4:26 AM

michal requested changes to this revision.Oct 11 2023, 1:38 AM

michal added inline comments.

keyserver/src/responders/thread-responders.js
69	If I remember correctly this will stop accepting requests from older clients (because they will still send `accountPassword`). We should probably leave the validator as it is and change the `ThreadDeletionRequest.accountPassword` to (optional) `empty` so flow complains if you try and do anything with it.
lib/actions/thread-actions.js
44	We shouldn't hide await inside of an another expression

This revision now requires changes to proceed.Oct 11 2023, 1:38 AM

inka added a child revision: D9399: [lib][web][native] Refactor actions in upload-actions.js.Oct 17 2023, 3:42 AM

Address review

Harbormaster completed remote builds in B23679: Diff 32633.Nov 2 2023, 10:56 AM

michal accepted this revision.Nov 3 2023, 5:19 AM

This revision is now accepted and ready to land.Nov 3 2023, 5:19 AM

Closed by commit rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2 (authored by inka). · Explain WhyNov 6 2023, 5:45 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0acb01c86240: [lib][web][native] Refactor actions in thread-actions.js pt.2.

inka mentioned this in D10591: [lib] Fix types in deleteThread.Jan 10 2024, 5:36 AM

inka mentioned this in rCOMM9fb4ba10c29b: [lib] Fix types in deleteThread.Jan 16 2024, 1:52 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

thread-responders.js

1 line

lib/

actions/

thread-actions.js

53 lines

components/

base-edit-thread-avatar-provider.react.js

9 lines

hooks/

promote-sidebar.react.js

9 lines

shared/

messages/

text-message-spec.js

9 lines

types/

thread-types.js

1 line

native/

chat/

settings/

add-users-modal.react.js

9 lines

color-selector-modal.react.js

9 lines

delete-thread.react.js

10 lines

thread-settings-description.react.js

5 lines

thread-settings-name.react.js

5 lines

community-creation/

community-creation-members.react.js

9 lines

web/

modals/

threads/

members/

add-members-modal.react.js

9 lines

settings/

thread-settings-delete-tab.react.js

11 lines

thread-settings-general-tab.react.js

9 lines

thread-settings-privacy-tab.react.js

9 lines

Diff 31686

keyserver/src/responders/thread-responders.js

Loading...

lib/actions/thread-actions.js

Loading...

lib/components/base-edit-thread-avatar-provider.react.js

Loading...

lib/hooks/promote-sidebar.react.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/types/thread-types.js

Loading...

native/chat/settings/add-users-modal.react.js

Loading...

native/chat/settings/color-selector-modal.react.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/chat/settings/thread-settings-description.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/community-creation/community-creation-members.react.js

Loading...

web/modals/threads/members/add-members-modal.react.js

Loading...

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...