lib/actions/thread-actions.js
161 ↗	(On Diff #31685)	In the future we will need to add a way to pick the keyserver we want to create a new community on. DMs and thick threads will also be handled differently. Those are the three cases in which the `parentThreadID` is not present. In all of them we currently want to use the Ashoat's keyserver.

inka added a child revision: D9371: [lib][web][native] Refactor actions in thread-actions.js pt.2.Oct 5 2023, 9:46 AM

michal accepted this revision.Oct 11 2023, 1:32 AM

michal added inline comments.

lib/actions/message-actions.js
484 ↗	(On Diff #31685)	We shouldn't hide await inside of an another expression

This revision is now accepted and ready to land.Oct 11 2023, 1:32 AM

Address review

Harbormaster completed remote builds in B23678: Diff 32632.Nov 2 2023, 10:45 AM

Closed by commit rCOMM635d1a0d6032: [lib][web][native] Refactor actions in thread-actions.js pt.1 (authored by inka). · Explain WhyNov 6 2023, 5:45 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM635d1a0d6032: [lib][web][native] Refactor actions in thread-actions.js pt.1.

This diff introduced a bunch of imports that don't include the .js file suffix. We aren't able to enforce that suffix via ESLint right now, but we should still try to always include the .js file suffix

This diff introduced a bunch of imports that don't include the .js file suffix. We aren't able to enforce that suffix via ESLint right now, but we should still try to always include the .js file suffix

Sorry about this. I noticed that VSCode sometimes even removes the .js that were previously present. I'm trying to add them even if that doesn't cause any errors

Revision Contents
Changeset List

Path

Size

lib/

actions/

message-actions.js

36 lines

thread-actions.js

229 lines

reducers/

message-reducer.js

2 lines

shared/

thread-utils.js

9 lines

native/

chat/

chat-input-bar.react.js

5 lines

compose-subchannel.react.js

12 lines

settings/

thread-settings-leave-thread.react.js

10 lines

thread-settings-media-gallery.react.js

5 lines

thread-settings-member-tooltip-modal.react.js

9 lines

toggle-pin-modal.react.js

11 lines

community-creation/

community-configuration.react.js

12 lines

input/

input-state-container.react.js

4 lines

navigation/

invite-link-modal.react.js

9 lines

roles/

change-roles-header-right-button.react.js

15 lines

create-roles-header-right-button.react.js

9 lines

role-utils.react.js

9 lines

web/

chat/

chat-input-bar.react.js

5 lines

thread-menu.react.js

11 lines

input/

input-state-container.react.js

4 lines

invite-links/

accept-invite-modal.react.js

9 lines

modals/

chat/

toggle-pin-modal.react.js

11 lines

threads/

create/

compose-subchannel-modal.react.js

12 lines

gallery/

thread-settings-media-gallery.react.js

5 lines

members/

change-member-role-modal.react.js

15 lines

member.react.js

9 lines

roles/

create-roles-modal.react.js

9 lines

delete-role-modal.react.js

9 lines

sidebar/

community-creation/

community-creation-modal.react.js

12 lines

Diff 32761

View Options

lib/actions/message-actions.js

// @flow		// @flow

import reduceCalendarFilters from './calendar-filters-reducer.js';		import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js';		import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js';		import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js';		import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js';		import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js';		import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js';		import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js';		import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js';		import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js';		import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js';		import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines	state: {
action,		action,
),		),
lifecycleState: reduceLifecycleState(state.lifecycleState, action),		lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action),		enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore,		reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action),		nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action),		dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action),		userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken(		commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken,		state.commServicesAccessToken,
action,		action,
),		),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),		inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore,		keyserverStore,
threadActivityStore: reduceThreadActivity(		threadActivityStore: reduceThreadActivity(
state.threadActivityStore,		state.threadActivityStore,
Show All 18 Lines

View Options

lib/actions/thread-actions.js

// @flow		// @flow

import reduceCalendarFilters from './calendar-filters-reducer.js';		import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js';		import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js';		import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js';		import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js';		import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js';		import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js';		import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js';		import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js';		import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js';		import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js';		import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines	state: {
action,		action,
),		),
lifecycleState: reduceLifecycleState(state.lifecycleState, action),		lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action),		enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore,		reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action),		nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action),		dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action),		userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken(		commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken,		state.commServicesAccessToken,
action,		action,
),		),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),		inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore,		keyserverStore,
threadActivityStore: reduceThreadActivity(		threadActivityStore: reduceThreadActivity(
state.threadActivityStore,		state.threadActivityStore,
Show All 18 Lines

View Options

lib/reducers/message-reducer.js

// @flow		// @flow

import reduceCalendarFilters from './calendar-filters-reducer.js';		import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js';		import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js';		import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js';		import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js';		import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js';		import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js';		import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js';		import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js';		import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js';		import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js';		import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines	state: {
action,		action,
),		),
lifecycleState: reduceLifecycleState(state.lifecycleState, action),		lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action),		enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore,		reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action),		nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action),		dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action),		userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken(		commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken,		state.commServicesAccessToken,
action,		action,
),		),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),		inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore,		keyserverStore,
threadActivityStore: reduceThreadActivity(		threadActivityStore: reduceThreadActivity(
state.threadActivityStore,		state.threadActivityStore,
Show All 18 Lines

View Options

lib/shared/thread-utils.js

// @flow		// @flow

import reduceCalendarFilters from './calendar-filters-reducer.js';		import reduceCalendarFilters from './calendar-filters-reducer.js';
import { reduceCalendarQuery } from './calendar-query-reducer.js';		import { reduceCalendarQuery } from './calendar-query-reducer.js';
import reduceDataLoaded from './data-loaded-reducer.js';		import reduceDataLoaded from './data-loaded-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js';
import { reduceDraftStore } from './draft-reducer.js';		import { reduceDraftStore } from './draft-reducer.js';
import reduceEnabledApps from './enabled-apps-reducer.js';		import reduceEnabledApps from './enabled-apps-reducer.js';
import { reduceEntryInfos } from './entry-reducer.js';		import { reduceEntryInfos } from './entry-reducer.js';
import { reduceIntegrityStore } from './integrity-reducer.js';		import { reduceIntegrityStore } from './integrity-reducer.js';
import reduceInviteLinks from './invite-links-reducer.js';		import reduceInviteLinks from './invite-links-reducer.js';
import reduceKeyserverStore from './keyserver-reducer.js';		import reduceKeyserverStore from './keyserver-reducer.js';
import reduceLifecycleState from './lifecycle-state-reducer.js';		import reduceLifecycleState from './lifecycle-state-reducer.js';
import { reduceLoadingStatuses } from './loading-reducer.js';		import { reduceLoadingStatuses } from './loading-reducer.js';
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Lines	state: {
action,		action,
),		),
lifecycleState: reduceLifecycleState(state.lifecycleState, action),		lifecycleState: reduceLifecycleState(state.lifecycleState, action),
enabledApps: reduceEnabledApps(state.enabledApps, action),		enabledApps: reduceEnabledApps(state.enabledApps, action),
reportStore,		reportStore,
nextLocalID: reduceNextLocalID(state.nextLocalID, action),		nextLocalID: reduceNextLocalID(state.nextLocalID, action),
dataLoaded: reduceDataLoaded(state.dataLoaded, action),		dataLoaded: reduceDataLoaded(state.dataLoaded, action),
userPolicies: policiesReducer(state.userPolicies, action),		userPolicies: policiesReducer(state.userPolicies, action),
deviceToken: reduceDeviceToken(state.deviceToken, action),
commServicesAccessToken: reduceServicesAccessToken(		commServicesAccessToken: reduceServicesAccessToken(
state.commServicesAccessToken,		state.commServicesAccessToken,
action,		action,
),		),
inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),		inviteLinksStore: reduceInviteLinks(state.inviteLinksStore, action),
keyserverStore,		keyserverStore,
threadActivityStore: reduceThreadActivity(		threadActivityStore: reduceThreadActivity(
state.threadActivityStore,		state.threadActivityStore,
Show All 18 Lines