Page MenuHomePhabricator

[lib][web][native] Refactor actions in thread-actions.js pt.1
ClosedPublic

Authored by inka on Oct 5 2023, 8:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 6:58 PM
Unknown Object (File)
Thu, Dec 26, 6:58 PM
Unknown Object (File)
Thu, Dec 26, 6:58 PM
Unknown Object (File)
Thu, Dec 26, 6:58 PM
Unknown Object (File)
Wed, Dec 25, 10:08 PM
Unknown Object (File)
Wed, Dec 25, 3:54 PM
Unknown Object (File)
Wed, Dec 25, 3:54 PM
Unknown Object (File)
Wed, Dec 25, 3:54 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

first two actions will be updated in next diff

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Oct 5 2023, 9:09 AM
lib/actions/thread-actions.js
161 ↗(On Diff #31685)

In the future we will need to add a way to pick the keyserver we want to create a new community on. DMs and thick threads will also be handled differently.
Those are the three cases in which the parentThreadID is not present. In all of them we currently want to use the Ashoat's keyserver.

michal added inline comments.
lib/actions/message-actions.js
484 ↗(On Diff #31685)

We shouldn't hide await inside of an another expression

This revision is now accepted and ready to land.Oct 11 2023, 1:32 AM

This diff introduced a bunch of imports that don't include the .js file suffix. We aren't able to enforce that suffix via ESLint right now, but we should still try to always include the .js file suffix

This diff introduced a bunch of imports that don't include the .js file suffix. We aren't able to enforce that suffix via ESLint right now, but we should still try to always include the .js file suffix

Sorry about this. I noticed that VSCode sometimes even removes the .js that were previously present. I'm trying to add them even if that doesn't cause any errors