HomePhabricator
Diffusion Comm 7aadfceb6f3d

[native] Bump minimum mobile codeVersion to 128

Description

[native] Bump minimum mobile codeVersion to 128

Summary:
I ran this query on my keyserver's production MariaDB instance to see what codeVersions were using Comm.

It's possible that users are logged out on older clients, and might start using those older clients again... so this isn't a guarantee that older clients don't exist.

But for those users, throwing new ServerError('client_version_unsupported') here will cause them to display an Alert prompting the user to upgrade their client. So I don't think it's a big concern.

The main impetus for this change is that it will allow us to improve performance for eg. thread joins by addressing this, which will potentially solve ENG-108, and other recent complaints (ENG-4376, ENG-4396).

This diff just bump the minimum required codeVersion, but following diffs simplify code where possible to reflect the new minimum required codeVersion.

Test Plan: I tested this whole stack together by playing around with the web app and making sure thread mutation endpoints seemed to work correctly

Reviewers: michal, kamil

Reviewed By: kamil

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8503

Details

Provenance
ashoatAuthored on Jul 15 2023, 7:11 PM
Reviewer
kamil
Differential Revision
D8503: [native] Bump minimum mobile codeVersion to 128
Parents
rCOMMae8eb251cfc8: [keyserver] Improve fetchKnownUserInfos query performance
Branches
Unknown
Tags
Unknown