Page MenuHomePhabricator

[native] Bump minimum mobile codeVersion to 128
ClosedPublic

Authored by ashoat on Jul 15 2023, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 4:00 PM
Unknown Object (File)
Mon, Jun 24, 8:37 PM
Unknown Object (File)
Thu, Jun 13, 6:46 PM
Unknown Object (File)
Tue, Jun 11, 9:59 AM
Unknown Object (File)
Sat, Jun 8, 9:51 AM
Unknown Object (File)
Mon, Jun 3, 11:36 PM
Unknown Object (File)
Mon, Jun 3, 11:36 PM
Unknown Object (File)
Mon, Jun 3, 10:14 PM
Subscribers

Details

Summary

I ran this query on my keyserver's production MariaDB instance to see what codeVersions were using Comm.

It's possible that users are logged out on older clients, and might start using those older clients again... so this isn't a guarantee that older clients don't exist.

But for those users, throwing new ServerError('client_version_unsupported') here will cause them to display an Alert prompting the user to upgrade their client. So I don't think it's a big concern.

The main impetus for this change is that it will allow us to improve performance for eg. thread joins by addressing this, which will potentially solve ENG-108, and other recent complaints (ENG-4376, ENG-4396).

This diff just bump the minimum required codeVersion, but following diffs simplify code where possible to reflect the new minimum required codeVersion.

Test Plan

I tested this whole stack together by playing around with the web app and making sure thread mutation endpoints seemed to work correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable