Page MenuHomePhabricator

[keyserver][lib] Simplify remaining thread responders following deprecation of old codeVersions
ClosedPublic

Authored by ashoat on Jul 15 2023, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 2:15 AM
Unknown Object (File)
Mon, Jun 24, 10:15 PM
Unknown Object (File)
Mon, Jun 24, 6:57 PM
Unknown Object (File)
Sun, Jun 23, 10:50 PM
Unknown Object (File)
Sat, Jun 22, 5:18 PM
Unknown Object (File)
Thu, Jun 13, 7:28 PM
Unknown Object (File)
Mon, Jun 3, 9:10 PM
Unknown Object (File)
Mon, Jun 3, 9:10 PM
Subscribers

Details

Summary

Doing these together because they share the same types and validators.

This is the last of four diffs that simplify the code, types, and validators for endpoints mutating threads. These can be simplified following the deprecation of older codeVersions in the first diff of this stack.

I finally update the code in thread-permission-updaters.js that I mentioned here, which is sort of the whole point of this stack. I'm hoping this change will improve performance of most of these endpoints.

Depends on D8508

Test Plan

I tested this whole stack together by playing around with the web app and making sure thread mutation endpoints seemed to work correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Really nice to see all those simplifications

This revision is now accepted and ready to land.Jul 17 2023, 4:20 AM