HomePhabricator
Diffusion Comm 7b02e7e5afa7

[native] rename instances of ImageModal to FullScreenViewModal in…

Description

[native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component

Summary:
Simple rename diff. This is step 2 in the list below

Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
  2. Correct the naming inside of FullScreenViewModal
  3. Lift out rendering of <Multimedia /> in favor for a generic content child
  4. Lift save content / copy content functionality out of FullScreenViewModal and make those optional props
  5. Lift the imageDimensions function out of FullScreenViewModal and introduce a required generic contentDimesions prop

Depends on D9360

Test Plan: flow

Reviewers: atul, inka

Reviewed By: atul

Subscribers: ashoat, tomek, wyilio

Differential Revision: https://phab.comm.dev/D9361

Details

Provenance
ginsuAuthored on Oct 4 2023, 11:46 AM
Reviewer
atul
Differential Revision
D9361: [native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component
Parents
rCOMM4bfd03b6a558: [native] introduce FullScreenViewModal
Branches
Unknown
Tags
Unknown