Page MenuHomePhabricator

[native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component
ClosedPublic

Authored by ginsu on Oct 4 2023, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 9:04 PM
Unknown Object (File)
Tue, Oct 1, 8:59 PM
Unknown Object (File)
Sat, Sep 21, 7:22 PM
Unknown Object (File)
Sat, Sep 21, 5:42 PM
Unknown Object (File)
Sat, Sep 21, 2:24 PM
Subscribers

Details

Summary

Simple rename diff. This is step 2 in the list below

Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
  2. Correct the naming inside of FullScreenViewModal
  3. Lift out rendering of <Multimedia /> in favor for a generic content child
  4. Lift save content / copy content functionality out of FullScreenViewModal and make those optional props
  5. Lift the imageDimensions function out of FullScreenViewModal and introduce a required generic contentDimesions prop

Depends on D9360

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Oct 4 2023, 12:21 PM

Looks like a straightforward find+replace. Thanks for laying out the outline of the stack in the summary, made it easier to make sense of each diff

This revision is now accepted and ready to land.Oct 4 2023, 5:10 PM