Details

Reviewers

atul
inka

Commits

rCOMMfb83d81c3057: [native] introduce children prop to FullScreenViewModal

Summary

Introduce children prop to FullScreenViewModal. This also factors out the rendering of Multimedia from FullScreenModal and instead we pass Multimedia in ImageModal This is step 3 in the list below

Outlined below are the steps I will take in this stack (each point here will be it's own diff):

Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
Correct the naming inside of FullScreenViewModal
Lift out rendering of <Multimedia /> in favor for a generic content child
Lift save content / copy content functionality out of FullScreenViewModal and make those optional props
Lift the imageDimensions function out of FullScreenViewModal and introduce a required generic contentDimesions prop

Depends on D9361

Test Plan

Confirmed that there were no regressions with the viewing an image multimedia message experience

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 4 2023, 10:21 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 10:21 AM

This seems pretty difficult to review... will break down this diff further

Harbormaster completed remote builds in B22974: Diff 31638.Oct 4 2023, 10:39 AM

ginsu retitled this revision from [native] introduce FullScreenViewModal to DO NOT REVIEW FOR NOW [native] introduce FullScreenViewModal .Oct 4 2023, 11:21 AM

update

ginsu retitled this revision from DO NOT REVIEW FOR NOW [native] introduce FullScreenViewModal to [native] introduce children prop to FullScreenViewModal.Oct 4 2023, 12:12 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9361: [native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component.

Harbormaster completed remote builds in B22977: Diff 31644.Oct 4 2023, 12:17 PM

Harbormaster completed remote builds in B22978: Diff 31645.Oct 4 2023, 12:26 PM

ginsu added a child revision: D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.Oct 4 2023, 1:24 PM

Looks good, let's memoize ImageModal before landing