HomePhabricator
Diffusion Comm 7c542a78a07f

[web] Always disable default authorName and always show avatars in message…

Description

[web] Always disable default authorName and always show avatars in message results modal

Summary:
This isn't urgent and not blocking anything, just something I noticed when viewing
pinned messages in the modal on web. Sometimes, the default authorName
is shown (we want to avoid that since we render one more lined up with the
Figma designs and its rendering is conditional so it won't always appear),
and sometimes the avatars don't show up.

Two really small changes here, both are already done on native:

  • In the modified object, sets startsCluster: true for the username
  • In the modified object, sets endsCluster: true for the avatar

Test Plan:
Confirm the before and avatar in the modal to validate the changes

Before:

Screenshot 2023-05-08 at 2.49.45 PM.png (1×1 px, 575 KB)

After:

Screenshot 2023-05-08 at 2.49.53 PM.png (1×1 px, 565 KB)

Reviewers: atul, ginsu, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D7747

Details

Provenance
RohanK6 <rohan.khanderia@gmail.com>Authored on May 8 2023, 11:50 AM
rohanCommitted on May 8 2023, 12:42 PM
Reviewer
ashoat
Differential Revision
D7747: [web] Always disable default authorName and always show avatars in message results modal
Parents
rCOMM086aa7bc67da: [native] Show a pin icon next to pinned messages
Branches
Unknown
Tags
Unknown