Page MenuHomePhabricator

[web] Always disable default authorName and always show avatars in message results modal
ClosedPublic

Authored by rohan on May 8 2023, 11:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 1:28 AM
Unknown Object (File)
Mon, Nov 11, 1:28 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Tue, Nov 5, 2:11 AM
Unknown Object (File)
Oct 4 2024, 1:26 AM
Unknown Object (File)
Oct 3 2024, 5:29 AM
Unknown Object (File)
Sep 12 2024, 6:50 AM
Unknown Object (File)
Sep 12 2024, 6:50 AM
Subscribers

Details

Summary

This isn't urgent and not blocking anything, just something I noticed when viewing
pinned messages in the modal on web. Sometimes, the default authorName
is shown (we want to avoid that since we render one more lined up with the
Figma designs and its rendering is conditional so it won't always appear),
and sometimes the avatars don't show up.

Two really small changes here, both are already done on native:

  • In the modified object, sets startsCluster: true for the username
  • In the modified object, sets endsCluster: true for the avatar
Test Plan

Confirm the before and avatar in the modal to validate the changes

Before:

Screenshot 2023-05-08 at 2.49.45 PM.png (1×1 px, 575 KB)

After:

Screenshot 2023-05-08 at 2.49.53 PM.png (1×1 px, 565 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan edited the summary of this revision. (Show Details)
rohan requested review of this revision.May 8 2023, 12:17 PM
This revision is now accepted and ready to land.May 8 2023, 12:41 PM