HomePhabricator
Diffusion Comm 88a455782466

[keyserver] Fetch getRustAPI inline with where it's used

Description

[keyserver] Fetch getRustAPI inline with where it's used

Summary:

  1. Since all of these callsites don't await on the Rust calls, we know we're not blocking execution and it doesn't really matter how early we call getRustAPI... delaying the Rust call for a couple seconds won't affect performance.
  2. In siweAuthResponder, we were missing an await, which could lead to a "unhandled promise rejection" error from Node. D6944 has the same issue; if it's landed before this diff with that unaddressed, I'll update this diff to also address that.

Test Plan: I only tested this by running Flow... I feel fairly confident about the changes, but it would be good if we could test the whole identity service / keyserver flow end-to-end after this and the other outstanding diffs are landed

Reviewers: varun, jon, atul

Reviewed By: varun

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D6953

Details

Provenance
ashoatAuthored on Mar 3 2023, 2:18 PM
Reviewer
varun
Differential Revision
D6953: [keyserver] Fetch getRustAPI inline with where it's used
Parents
rCOMMa1d55785a1c3: [lib] Introduce `identityKeysBlobValidator` and use in…
Branches
Unknown
Tags
Unknown