Page MenuHomePhabricator

[keyserver] Fetch getRustAPI inline with where it's used
ClosedPublic

Authored by ashoat on Mar 3 2023, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 12:28 AM
Unknown Object (File)
Tue, Feb 27, 11:27 PM
Unknown Object (File)
Tue, Feb 27, 11:27 PM
Unknown Object (File)
Tue, Feb 27, 11:27 PM
Unknown Object (File)
Tue, Feb 27, 11:26 PM
Unknown Object (File)
Feb 27 2024, 1:50 AM
Unknown Object (File)
Feb 21 2024, 4:01 AM
Unknown Object (File)
Feb 20 2024, 10:07 PM
Subscribers

Details

Summary
  1. Since all of these callsites don't await on the Rust calls, we know we're not blocking execution and it doesn't really matter how early we call getRustAPI... delaying the Rust call for a couple seconds won't affect performance.
  2. In siweAuthResponder, we were missing an await, which could lead to a "unhandled promise rejection" error from Node. D6944 has the same issue; if it's landed before this diff with that unaddressed, I'll update this diff to also address that.
Test Plan

I only tested this by running Flow... I feel fairly confident about the changes, but it would be good if we could test the whole identity service / keyserver flow end-to-end after this and the other outstanding diffs are landed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable