Page MenuHomePhabricator

[keyserver] Fetch getRustAPI inline with where it's used
ClosedPublic

Authored by ashoat on Mar 3 2023, 2:22 PM.
Tags
None
Referenced Files
F1676745: D6953.diff
Mon, Apr 29, 2:29 AM
F1673952: D6953.id23446.diff
Sun, Apr 28, 12:36 PM
F1673951: D6953.id23436.diff
Sun, Apr 28, 12:36 PM
F1673915: D6953.id.diff
Sun, Apr 28, 12:33 PM
F1673888: D6953.diff
Sun, Apr 28, 12:11 PM
Unknown Object (File)
Sat, Apr 27, 7:04 PM
Unknown Object (File)
Thu, Apr 18, 4:26 AM
Unknown Object (File)
Mar 28 2024, 7:25 PM
Subscribers

Details

Summary
  1. Since all of these callsites don't await on the Rust calls, we know we're not blocking execution and it doesn't really matter how early we call getRustAPI... delaying the Rust call for a couple seconds won't affect performance.
  2. In siweAuthResponder, we were missing an await, which could lead to a "unhandled promise rejection" error from Node. D6944 has the same issue; if it's landed before this diff with that unaddressed, I'll update this diff to also address that.
Test Plan

I only tested this by running Flow... I feel fairly confident about the changes, but it would be good if we could test the whole identity service / keyserver flow end-to-end after this and the other outstanding diffs are landed

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/identity
Lint
No Lint Coverage
Unit
No Test Coverage