HomePhabricator
Diffusion Comm 8cc7bcccd127

[web] introduce subheader prop to modal component

Description

[web] introduce subheader prop to modal component

Summary:
This diff introduces a subheader prop to the modal component. Sometimes we want to render an element in between the header and the modal children content, but we want this element to not follow the spacing rules for the modal children. These elements can be things like banners, tabs, etc. For example:

Screenshot 2023-12-07 at 2.47.47 PM.png (1×3 px, 802 KB)

The subheader prop will extend the entire width of the modal, perfect for elements like banners + tabs.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10232

Test Plan:
Here is an example of using the subheader prop with the community creation modal

Screenshot 2023-12-07 at 2.53.26 PM.png (1×3 px, 802 KB)

Reviewers: atul, rohan, kamil

Reviewed By: rohan

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10234

Details

Provenance
ginsuAuthored on Dec 6 2023, 10:30 PM
Reviewer
rohan
Differential Revision
D10234: [web] introduce subheader prop to modal component
Parents
rCOMM9dd68c7c57e0: [web] cleanup password change modal
Branches
Unknown
Tags
Unknown