HomePhabricator
Diffusion Comm 8d099ca1d8ab

[Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors

Description

[Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors

Summary:
Flow was printing errors because it was having trouble deducing the types for these selectors. Adding typehints solved the errors.

The only exception is the case where I added a threadInfo.containingThreadID check. This was necessary because that value was used to index into a collection that didn't support null/undefined values.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9707

Test Plan: Confirm the Flow errors go away

Reviewers: tomek

Reviewed By: tomek

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9708

Details

Provenance
ashoatAuthored on Nov 4 2023, 11:16 AM
Reviewer
tomek
Differential Revision
D9708: [Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors
Parents
rCOMMe48d27779c09: [Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers
Branches
Unknown
Tags
Unknown