HomePhabricator
Diffusion Comm 8ddbe5330bb6

[web] Use shades-black-70 for thread-preview-secondary

Description

[web] Use shades-black-70 for thread-preview-secondary

Summary:
In the last diff, I updated web behavior to match native and use this color when the last message on a read thread is robotext.

That change made the contrast on the robotext look bad. Previously we had this low contrast for just the username, but it seems more stark when it applies to a whole message.

I would rather use what's on native: #999999 for --thread-color-read (primary), and #555555 for --thread-preview-secondary (in dark mode). In contrast, on web today we're using #808080 and #404040 (respectively), the latter of which I update to #666666 in this diff.

The downside is that the primary and secondary colors now seem a bit too similar. I wonder if we need an exception to the design system here?

Depends on D6358

Test Plan:

beforeafter
Screenshot 2023-01-23 at 5.24.25 PM.png (1×812 px, 135 KB)
Screenshot 2023-01-23 at 5.30.19 PM.png (1×818 px, 136 KB)

(identical except "ashoat added commbot" near the bottom, and usernames prefixed to message previews)

Reviewers: inka, ginsu, atul, tomek

Reviewed By: atul

Differential Revision: https://phab.comm.dev/D6359

Details

Provenance
ashoatAuthored on Jan 23 2023, 2:30 PM
Reviewer
atul
Differential Revision
D6359: [web] Use shades-black-70 for thread-preview-secondary
Parents
rCOMM9c46d3471f37: [web] Use new style prop passed from getMessagePreview
Branches
Unknown
Tags
Unknown