Page MenuHomePhabricator

[web] Use shades-black-70 for thread-preview-secondary
ClosedPublic

Authored by ashoat on Jan 23 2023, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:26 AM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Tue, Oct 22, 3:18 AM
Unknown Object (File)
Tue, Oct 22, 3:18 AM
Unknown Object (File)
Tue, Oct 22, 3:00 AM
Unknown Object (File)
Tue, Oct 22, 12:28 AM
Unknown Object (File)
Oct 4 2024, 12:21 PM
Subscribers
None

Details

Summary

In the last diff, I updated web behavior to match native and use this color when the last message on a read thread is robotext.

That change made the contrast on the robotext look bad. Previously we had this low contrast for just the username, but it seems more stark when it applies to a whole message.

I would rather use what's on native: #999999 for --thread-color-read (primary), and #555555 for --thread-preview-secondary (in dark mode). In contrast, on web today we're using #808080 and #404040 (respectively), the latter of which I update to #666666 in this diff.

The downside is that the primary and secondary colors now seem a bit too similar. I wonder if we need an exception to the design system here?

Depends on D6358

Test Plan
beforeafter
Screenshot 2023-01-23 at 5.24.25 PM.png (1×812 px, 135 KB)
Screenshot 2023-01-23 at 5.30.19 PM.png (1×818 px, 136 KB)

(identical except "ashoat added commbot" near the bottom, and usernames prefixed to message previews)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable