Page MenuHomePhabricator

[lib] Return style of text from getMessagePreview
ClosedPublic

Authored by ashoat on Jan 23 2023, 2:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 2:49 AM
Unknown Object (File)
Fri, Nov 22, 2:49 AM
Unknown Object (File)
Fri, Nov 22, 2:49 AM
Unknown Object (File)
Fri, Nov 22, 2:47 AM
Unknown Object (File)
Nov 13 2024, 3:57 PM
Unknown Object (File)
Nov 12 2024, 12:26 AM
Unknown Object (File)
Nov 12 2024, 12:26 AM
Unknown Object (File)
Nov 12 2024, 12:26 AM
Subscribers
None

Details

Summary

I noticed that native/chat/message-preview.react.js wasn't using getMessagePreview, even though much of the logic was the same.

I wanted to unify the codepaths, but there is was one thing that native needed that wasn't being returned by getMessagePreview: what style to render each of the parts as.

I also noticed that web was rendering styles slightly different that native, which will be fixed in the next diff. This diff doesn't actually use the newly-returned style field... it just updates the code to return it.

Test Plan

Tested in combo with following diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable