HomePhabricator
Diffusion Comm 90a03ed80d7e

[backup-service] Improve blob client logging

Description

[backup-service] Improve blob client logging

Summary:
Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Now these functions do not need to be async anymore. The connection errors are now handled inside the spawned Tokio task. I improved logging the connection error (it is now displayed immediately instead of finishing and waiting for the terminate() method to handle errors). Also, the start() signature can be simplified not to return Result

Depends on D6386

Test Plan: Ran backup service integration tests. Killed blob service. Ran tests again and checked if the erorr is handled as expected

Reviewers: varun, jon, michal, tomek

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6387

Details

Provenance
bartekAuthored on Jan 25 2023, 1:54 AM
Reviewer
tomek
Differential Revision
D6387: [backup-service] Improve blob client logging
Parents
rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers
Branches
Unknown
Tags
Unknown